Repository navigation
fix(infrastructure): resume setup with a secret-backed origin - #285
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The retained fingerprint can still block valid resumes after image and deploy_hub normalization, while suffix-only Key Vault checks mistake hexadecimal secret names for pinned versions.
5 open issues
Stale image and deploy_hub values still block resume · New Unversioned secret names can be mistaken for pinned versions · New Valid versionless references may be rejected as already pinned · New Tests do not cover pinning unversioned shared references · New Rejection tests do not verify legacy parsing reaches input review · New
What changed in this PR
This PR improves Azure sign-in setup recovery when setup is interrupted after saving inputs that use a Key Vault-backed application origin.
Changes:
- Records input fingerprints and original secret references as recovery evidence.
- Recognizes permitted reference pinning while rejecting conflicting changes and unresolved writes.
- Adds recovery and legacy-progress tests, and documents the resume behavior.
| File | Description |
|---|---|
infrastructure/README.md |
Documents secret-backed origin recovery and legacy-file limits. |
infrastructure/azure/post/progress/index.ts |
Stores and validates reference-only recovery evidence. |
infrastructure/azure/post/progress/index.test.ts |
Adds interrupted-setup, rejection, and legacy-progress coverage. |
Review effort: Max (adaptive)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why
Sign-in setup can stop after saving desired inputs but before completing its progress file. Resuming then rejects an unchanged Key Vault-backed origin because the origin is stored as a secret reference rather than a plain input.
What changes
New sign-in progress files retain a fingerprint of unchanged inputs and the original secret references. Resume uses that evidence to recognize the saved configuration, allowing an unversioned origin or shared authentication reference to become pinned while rejecting changed pinned versions, unrelated inputs or references, and unresolved secret writes. No secret values or extra Key Vault reads are needed.
Older progress files without this evidence still stop for review if their inputs changed. Configuration behavior and completion-marker ordering are unchanged.